toc without highlighting and without mobile view #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinxmo
changed the title
Fil
force-pushed
the
cindy/render-toc
branch
from
8e60cfe to
046272b
Compare
Fil
force-pushed
the
cindy/render-toc
branch
from
11baefa to
4c45277
Compare
cinxmo
commented
Nov 21, 2023
| @@ -5,6 +5,6 @@ export default { | |||
| {path: "/sub/two", name: "Two"} | |||
| ], | |||
| toc: { | |||
| label: "Contents" | |||
| label: "On this page" | |||
There was a problem hiding this comment.
do we want to follow the exact same naming as Vitepress? I think we should opt for something different
There was a problem hiding this comment.
this is the override test, it needs to be different from the new default which is "Contents"
Fil
approved these changes
Nov 21, 2023
|
We discussed fast-follows:
This css rule will show a hamburger next to (or instead of) the toc header: #observablehq-toc summary::before {
content: '☰ ';
} |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and simple TOC without the following:
client.jshere using a doubly linked list to keep track of theprev,current, andnextsections. It could be too slow to react to ascrollevent every single time to determine which section should be highlighted.